-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Cygwin CI to GHA #2032
Switch Cygwin CI to GHA #2032
Conversation
Duh, the default shell for Cygwin action is PowerShell, trying its multi-line break instead... Edit: Switched to bash eventually. Also, not sure why AppVeyor is still attempting to run when the recipe has been removed? |
4882a55
to
75f46d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks about right. Let's see how/if it works out on the CI.
You're using the correct approach to install the dependencies and build with CMake without using conan. I've never succeeded in building with conan on Cygwin.
The code in appveyor_mingw_cygwin.yml use apt-cyg to install the dependencies and builds with cmake. Appveyor runs the cmd shell.
75f46d9
to
7912345
Compare
Yeah, and had to turn unit test off (same on AppVeyor) as there is not gtest on Cygwin available ootb. The action is made by the same person who did the action for MSYS2 setup (and incidentally the VS shell), so should be usable 🤞 |
7912345
to
6dfae3a
Compare
Almost there, now just a couple of tests fail, presumably because of line ending difference: |
Here are the notes I made when I created this last year: https://help.appveyor.com/discussions/questions/51961-building-on-mingw-64-and-cygwin64 When this PR flies, we don't need appveyor to run appveyor_mingw_cygwin.yml at all. I can't remember how this is triggered. I'm fairly sure I had to register something on the appveyor web-site. |
6dfae3a
to
7322209
Compare
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #2032 +/- ##
=================================================
Coverage 58.74% 58.74%
=================================================
Files 146 146
Lines 23004 23004
Branches 12596 12596
=================================================
Hits 13513 13513
Misses 6689 6689
Partials 2802 2802 Continue to review full report at Codecov.
|
914aaf8
to
4edcccb
Compare
@kmilos Appveyor is running the cmd.exe (DOS console) and I execute bash to run the bash build script. I build the bash build script line-by-line with
|
I'm fairly sure the build is failing in Appveyor because you've deleted appveyor_mingw_cygwin.yml. I think I had to register something with appveyor to tell him to use that file. I remember thinking "this will only work on 0.27-maintenance". Ummm. I can't remember how it works and I can't find anything on appveyor. @kevinbackhouse Do you know how appveyor knows to read the file appveyor_mingw_cygwin.yml? |
Thanks Robin, I was well aware of that. The problem was that the default bash launcher suggested by the action author changes the working directory to $HOME even w/ But we're back to square one (same as PowerShell), there are still a couple of failing tests... |
4edcccb
to
52cfd75
Compare
I haven't understood what you are saying about the shell. Most of the tests pass, so it's mostly working fine. This looks like a solid/repeatable error. I'll try this after lunch on Windows. At the moment, I'm giving README.md a thorough overhaul to deal with ctest. |
52cfd75
to
56545fe
Compare
I've found the appveyor settings. https://ci.appveyor.com/project/clanmills/exiv2/settings. I will delete the project. Later today, I'll investigate the other build failures on Windows. There can't be much wrong. |
Please wait until we get this working ;) The suggested workaround to check out Unix line endings also doesn't work currently... I'm taking a break from this one... |
Whoops. I've already deleted it. I asked in a review for that code concerning the line-endings to be changed and the engineer refused. He's the only contributor I have ever fired. |
56545fe
to
057f4c7
Compare
Ok, figured out why the git config wasn't working (executed in the wrong shell), so this is my last attempt before touching tests. |
Bingo! |
057f4c7
to
589079a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Finally all the pipelines running on GHA! 🎊
You're almost as smart as I used to be! Do you know the Country Song "As Good As I One Was"? https://www.youtube.com/watch?v=ldQrapQ4d0Y |
Can't say I did :D |
"I'm not as good as I once was. |
No description provided.